Bug in interface/request/UserRequestList.php?

Discussion for TimeTrex open source community developers.
Locked
joel
Posts: 11
Joined: Tue Dec 22, 2009 2:06 pm

Bug in interface/request/UserRequestList.php?

Post by joel »

in interface/request/UserRequestList.php, when the page asks "Does the signed in user have any direct reports whose requests for time off can be viewed", it does a:

$permission_children_ids = getHierarchyChildrenByCompanyIdAndUserIdAndObjectTypeID( $current_company->getId(), $current_user->getId() )

But, this call will use the default $object_type_id of 100, but requests are a object_type_id of 50.

Seems like a bug to me.

jr
shaunw
Posts: 7839
Joined: Tue Sep 19, 2006 2:22 pm

Re: Bug in interface/request/UserRequestList.php?

Post by shaunw »

This seems fine to me as the permission object type is always used for determining which supervisor can see which employees (or employees requests in this case). The request object type is only used for determining where requests are routed too for authorization.
Locked